From 729ea9ad5272d57a76e602ecddef550b5c76a8c3 Mon Sep 17 00:00:00 2001 From: GPSBabel <12013583+GPSBabelDeveloper@users.noreply.github.com> Date: Wed, 12 Apr 2023 19:35:51 -0500 Subject: [PATCH] Remove holux gm-100 format. (#1065) Following through with plan announced Feb 28, 2022. This was a serial unit from the turn of the century. Holux is out of business. We've done nothing but mechanical maintenance on this format for years. Co-authored-by: Robert Lipe --- CMakeLists.txt | 3 --- holux.cc => deprecated/holux.cc | 0 holux.h => deprecated/holux.h | 0 reference/format0.txt | 1 - reference/format1.txt | 1 - reference/format2.txt | 1 - reference/format3.txt | 2 -- reference/help.txt | 1 - testo.d/holux.test | 8 -------- vecs.cc | 9 --------- xmldoc/formats/holux.xml | 27 --------------------------- 11 files changed, 53 deletions(-) rename holux.cc => deprecated/holux.cc (100%) rename holux.h => deprecated/holux.h (100%) delete mode 100644 testo.d/holux.test delete mode 100644 xmldoc/formats/holux.xml diff --git a/CMakeLists.txt b/CMakeLists.txt index af5e5ff9c..505e306f9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -92,7 +92,6 @@ set(ALL_FMTS ${MINIMAL_FMTS} globalsat_sport.cc gtm.cc gtrnctr.cc - holux.cc html.cc humminbird.cc igc.cc @@ -227,7 +226,6 @@ set(HEADERS grtcirc.h gtrnctr.h heightgrid.h - holux.h humminbird.h html.h inifile.h @@ -400,7 +398,6 @@ set(TESTS gtm gtrnctr height - holux humminbird iblue747 igc diff --git a/holux.cc b/deprecated/holux.cc similarity index 100% rename from holux.cc rename to deprecated/holux.cc diff --git a/holux.h b/deprecated/holux.h similarity index 100% rename from holux.h rename to deprecated/holux.h diff --git a/reference/format0.txt b/reference/format0.txt index 13feb64e4..fcc70a38a 100644 --- a/reference/format0.txt +++ b/reference/format0.txt @@ -26,7 +26,6 @@ arc txt GPSBabel arc filter file gpsdrive GpsDrive Format gpsdrivetrack GpsDrive Format for Tracks gpx gpx GPX XML -holux wpo Holux (gm-100) .wpo Format m241-bin bin Holux M-241 (MTK based) Binary File Format m241 Holux M-241 (MTK based) download html html HTML Output diff --git a/reference/format1.txt b/reference/format1.txt index 56235675d..0647159ab 100644 --- a/reference/format1.txt +++ b/reference/format1.txt @@ -31,7 +31,6 @@ file arc txt GPSBabel arc filter file file gpsdrive GpsDrive Format file gpsdrivetrack GpsDrive Format for Tracks file gpx gpx GPX XML -file holux wpo Holux (gm-100) .wpo Format file m241-bin bin Holux M-241 (MTK based) Binary File Format serial m241 Holux M-241 (MTK based) download file html html HTML Output diff --git a/reference/format2.txt b/reference/format2.txt index 9da8f0f59..26ff4eb57 100644 --- a/reference/format2.txt +++ b/reference/format2.txt @@ -31,7 +31,6 @@ file rw---- arc txt GPSBabel arc filter file file rw---- gpsdrive GpsDrive Format file rw---- gpsdrivetrack GpsDrive Format for Tracks file rwrwrw gpx gpx GPX XML -file rw---- holux wpo Holux (gm-100) .wpo Format file r-r--- m241-bin bin Holux M-241 (MTK based) Binary File Format serial --r--- m241 Holux M-241 (MTK based) download file -w---- html html HTML Output diff --git a/reference/format3.txt b/reference/format3.txt index a462ade38..cbfa55b61 100644 --- a/reference/format3.txt +++ b/reference/format3.txt @@ -426,8 +426,6 @@ option gpx garminextensions Add info (depth) as Garmin extension boolean http option gpx elevprec Precision of elevations, number of decimals integer 3 https://www.gpsbabel.org/WEB_DOC_DIR/fmt_gpx.html#fmt_gpx_o_elevprec -file rw---- holux wpo Holux (gm-100) .wpo Format holux - https://www.gpsbabel.org/WEB_DOC_DIR/fmt_holux.html file r-r--- m241-bin bin Holux M-241 (MTK based) Binary File Format m241-bin https://www.gpsbabel.org/WEB_DOC_DIR/fmt_m241-bin.html option m241-bin csv MTK compatible CSV output file string https://www.gpsbabel.org/WEB_DOC_DIR/fmt_m241-bin.html#fmt_m241-bin_o_csv diff --git a/reference/help.txt b/reference/help.txt index 796001547..abdfc5672 100644 --- a/reference/help.txt +++ b/reference/help.txt @@ -215,7 +215,6 @@ File Types (-i and -o options): humminbirdextensio (0/1) Add info (depth) as Humminbird extension garminextensions (0/1) Add info (depth) as Garmin extension elevprec Precision of elevations, number of decimals - holux Holux (gm-100) .wpo Format m241-bin Holux M-241 (MTK based) Binary File Format csv MTK compatible CSV output file m241 Holux M-241 (MTK based) download diff --git a/testo.d/holux.test b/testo.d/holux.test deleted file mode 100644 index 4b30d1687..000000000 --- a/testo.d/holux.test +++ /dev/null @@ -1,8 +0,0 @@ - -# Holux support is a little funky to test. Becuase it loses precision, -# if we convert it to another format, we lose accuracy (rounding) in the -# coords, so converting it so something else and comparing it never works. -# So we verify that we can read the reference and write it and get an -# identical reference. -gpsbabel -i holux -f ${REFERENCE}/paris.wpo -o holux -F ${TMPDIR}/paris.wpo -bincompare ${REFERENCE}/paris.wpo ${TMPDIR}/paris.wpo diff --git a/vecs.cc b/vecs.cc index 4f87e9883..1233a1b71 100644 --- a/vecs.cc +++ b/vecs.cc @@ -75,7 +75,6 @@ extern ff_vecs_t geo_vecs; extern ff_vecs_t garmin_vecs; extern ff_vecs_t ozi_vecs; #if MAXIMAL_ENABLED -extern ff_vecs_t holux_vecs; extern ff_vecs_t tpg_vecs; extern ff_vecs_t tpo2_vecs; extern ff_vecs_t tpo3_vecs; @@ -128,7 +127,6 @@ struct Vecs::Impl { KmlFormat kml_fmt; #if MAXIMAL_ENABLED LowranceusrFormat lowranceusr_fmt; - LegacyFormat holux_fmt {holux_vecs}; LegacyFormat tpg_fmt {tpg_vecs}; LegacyFormat tpo2_fmt {tpo2_vecs}; LegacyFormat tpo3_fmt {tpo3_vecs}; @@ -250,13 +248,6 @@ struct Vecs::Impl { "usr", nullptr, }, - { - &holux_fmt, - "holux", - "Holux (gm-100) .wpo Format", - "wpo", - nullptr, - }, { &tpg_fmt, "tpg", diff --git a/xmldoc/formats/holux.xml b/xmldoc/formats/holux.xml deleted file mode 100644 index 1af3b3264..000000000 --- a/xmldoc/formats/holux.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - The Holux gm-100 (e-fox) gps receiver uses standard -compact flash cards. File formats were provided by Holux-Taiwan -holux.com to the author. -The code was tested against version 2.27E1; other versions and -receivers may work but have not been explicitly tested. Anyone with -information on other Holux receivers is encouraged to contact -jochen@bauerbahn.net. - - When copying the .wpo file to a flash card, the file must -be named tempwprt.wpo as the -receiver will ignore all other files. - - Comparing the waypoints of a .wpo files against other -formats like .gpx you may notice a small difference in the latitude -and longitude values. The reason is the low resolution of the -coordinates in the wpo file format. In a .wpo file the resolution is -1/10"; in gpx for example it is 1/100". A a practical matter, this -loss is only about 1.7 meters (5 feet). - - The generated waypoint files can also be used by MapShow -version 1.14. This program is free of charge from the Holux web site. - - This format was contributed by Jochen Becker. - -- 2.30.2